Skip to content

remove the old image proc_system_containers.sh #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2025
Merged

remove the old image proc_system_containers.sh #789

merged 3 commits into from
Jul 10, 2025

Conversation

@mohitrajain
Copy link
Contributor

@mohitrajain mohitrajain commented Jun 20, 2025 •
edited
Loading

Change type

  • Fix
  • Feature
  • Documentation
  • Security / Upgrade

Basic information

  • THIS CHANGE REQUIRES A DEPLOYMENT PACKAGE RELEASE
  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE

Testing

  • I ran/applied the changes myself, in a test environment.
  • The CI job attached to this repo will test it for me.

Tracking

  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Knowledge Transfer

  • An Asciinema session is attached to the Jira ticket.

Motivation

Objective

Reason

Use case

@mohitrajain mohitrajain requested review from a team and julialongtin as code owners June 20, 2025 07:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sghosh23
sghosh23 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@sghosh23 sghosh23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

sghosh23
sghosh23 reviewed Jun 20, 2025
View reviewed changes
Copy link
Contributor

@sghosh23 sghosh23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be also clean up:
quay.io/jetstack/cert-manager-controller:v1.16.3
quay.io/jetstack/cert-manager-cainjector:v1.16.3
quay.io/jetstack/cert-manager-webhook:v1.16.3
quay.io/jetstack/cert-manager-startupapicheck:v1.16.3

We are delivering them via chart

@mohitrajain
Copy link
Contributor Author

mohitrajain commented Jun 20, 2025

@sghosh23 we should handle cleaning cert-manager in a separate PR, as it is present in multiple places as of now for both demo and default builds. we might also need to fix the documentation about cert-manager.

@sghosh23 sghosh23 mentioned this pull request Jun 23, 2025
Closed
11 tasks
Veki301
Veki301 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@Veki301 Veki301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julialongtin julialongtin merged commit 180340e into master Jul 10, 2025
5 checks passed
@julialongtin julialongtin deleted the remove-old-image-test branch July 10, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sghosh23 sghosh23 sghosh23 approved these changes

@Veki301 Veki301 Veki301 approved these changes

@julialongtin julialongtin Awaiting requested review from julialongtin julialongtin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mohitrajain @sghosh23 @Veki301 @julialongtin